Adding support for setting the fetch API credentials mode #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Jun 26, 2024
JordonPhillips
approved these changes
Jun 27, 2024
| /** | ||
| * A string indicating whether credentials will be sent with the request always, never, or only when sent to a same-origin URL. Sets request's credentials. | ||
| */ | ||
| credentials?: "include" | "omit" | "same-origin" | undefined | string; |
There was a problem hiding this comment.
Nit: maybe credentialsMode instead?
There was a problem hiding this comment.
credentials matches the property on the Fetch request itself. I think it makes sense to keep this property name consistent with how it's used on the request.
kuhe
approved these changes
Jun 27, 2024
kuhe
reviewed
Jun 27, 2024
kuhe
reviewed
Jun 27, 2024
| @@ -77,6 +77,7 @@ export class FetchHttpHandler implements HttpHandler<FetchHttpHandlerConfig> { | |||
| } | |||
| const requestTimeoutInMs = this.config!.requestTimeout; | |||
| const keepAlive = this.config!.keepAlive === true; | |||
| const credentials = this.config!.credentials as RequestInit["credentials"]; | |||
There was a problem hiding this comment.
we're already using RequestInit, so RequestCredentials is probably globally available too, but I'm being conservative here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 1296
Description of changes: Adds support to set credentials in the fetch API to
include,same-origin, oromit.If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.