-
Notifications
You must be signed in to change notification settings - Fork 105
Adding support for setting the fetch API credentials mode #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@smithy/fetch-http-handler": minor | ||
"@smithy/types": minor | ||
--- | ||
|
||
Adding support for setting the fetch API credentials mode |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,4 +90,11 @@ export interface FetchHttpHandlerOptions { | |
* these limitations before enabling keepalive. | ||
*/ | ||
keepAlive?: boolean; | ||
|
||
/** | ||
* A string indicating whether credentials will be sent with the request always, never, or | ||
* only when sent to a same-origin URL. | ||
* @see https://developer.mozilla.org/en-US/docs/Web/API/Request/credentials | ||
*/ | ||
credentials?: "include" | "omit" | "same-origin" | undefined | string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: maybe credentialsMode instead? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're already using
RequestInit
, soRequestCredentials
is probably globally available too, but I'm being conservative here.