Use server symbol provider in protocol test gen #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
update-ssdk-request-tests
branch
from
c26e756 to
59edca7
Compare
|
I discovered some issues with the symbol provider change that make this impossible to test, so closing this for now until I get that resolved. |
Merged
JordonPhillips
force-pushed
the
update-ssdk-request-tests
branch
from
3fcd287 to
976711c
Compare
adamthom-amzn
approved these changes
Mar 15, 2021
| /** | ||
| * Generates server operation types. | ||
| */ | ||
| final class ServerCommandGenerator implements Runnable { |
There was a problem hiding this comment.
I don't like the association of the term command with this at all (but no, I don't have a better idea off the top of my head)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the server protocol test gen to use the server symbol provider. It also splits up the server / client "command" generators because having them all in one was causing client code to be generated in the server files. Lastly, I changed the folder for the server operation types to "operation" since typescript special cases "types" and that was causing generation issues.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.