Add ssdk response tests #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
reviewed
Mar 15, 2021
...-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ServerCommandGenerator.java
Outdated
Show resolved
Hide resolved
...-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ServerCommandGenerator.java
Outdated
Show resolved
Hide resolved
...-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ServerCommandGenerator.java
Outdated
Show resolved
Hide resolved
This updates the compare octet and compare unknown protocol test test helpers to specifically take an Encoder rather than a client config.
This adds protocol test generation for server reponses, excluding errors. At time of writing 5 protocol tests fail due to differences in how servers and clients are excpected to serialize empty bodies.
JordonPhillips
force-pushed
the
ssdk-response-tests
branch
from
295127f to
fb5b097
Compare
adamthom-amzn
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds protocol test generation for server responses, excluding errors. At time of writing 5 protocol tests fail due to differences in how servers and clients are expected to serialize empty bodies.
As part of that, this updates the compare octet and compare unknown protocol test test helpers to specifically take an Encoder rather than a client config.
This depends on #284 ,
the first two commits are from that PR.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.