Skip to content

Add mode switch options to system menu #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 19, 2022
Merged

Add mode switch options to system menu #116

merged 4 commits into from
May 19, 2022

Conversation

LeeLeahy2
Copy link
Contributor

Extend the system menu to add:

  • B) Switch to Base mode
  • R) Switch to Rover mode
  • W) Switch to WiFi Config mode

nseidle and others added 4 commits February 21, 2022 13:56
@nseidle
Merge pull request #80 from sparkfun/release_candidate
ca2e93e 
Supplement v1.10 - Programming batch fix
@nseidle
Merge pull request #98 from sparkfun/release_candidate
0a7e73b 
Real time delivery of ESF-RAW. Add cyclic logging, profiles, faster boot time.
@nseidle
Merge pull request #106 from sparkfun/release_candidate
81089c1 
Fix UART1 incorrect baud rate
@LeeLeahy2
Add mode switch options to system menu
b959140 
Extend the system menu to add:
* B) Switch to Base mode
* R) Switch to Rover mode
* W) Switch to WiFi Config mode
@nseidle nseidle changed the base branch from main to release_candidate May 12, 2022 14:51
@nseidle
Copy link
Member

nseidle commented May 12, 2022

Hi Lee - A few things:

  • Thanks for all the PRs! These look good.
  • Please don't point PRs at the main branch, point them at the release_candidate (I fixed this PR, please fix future PRs)
  • This is good functionality to add but I don't want to extend the main menu by another three slots. Please create a submenu and move them there.
  • I have mixed too many letters and numbers in the menu system. I plan to move to a letter for entering sub menus and a number for select an option. Help me get there.

@nseidle
Copy link
Member

nseidle commented May 19, 2022

This works well! Thank you.

@nseidle nseidle merged commit f8029da into sparkfun:release_candidate May 19, 2022
@LeeLeahy2 LeeLeahy2 deleted the mode-switch branch June 3, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeeLeahy2 @nseidle