Use Brave BOM instead of only managing a single Zipkin dependency #32614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
marcingrzejszczak
force-pushed
the
observabilityBoms
branch
from
8b178a8 to
b87d2b7
Compare
marcingrzejszczak
changed the title
wilkinsona
reviewed
Oct 6, 2022
| group("io.zipkin.reporter2") { | ||
| modules = [ | ||
| "zipkin-sender-urlconnection" | ||
| library("Zipkin", "5.14.1") { |
There was a problem hiding this comment.
I think we should rename this. Perhaps "Zipkin Brave" or just "Brave". What would you recommend?
There was a problem hiding this comment.
OpenZipkin Brave would be most correct I guess (https://github.com/openzipkin/brave).
There was a problem hiding this comment.
They don't seem to use "Open Zipkin" anywhere really though. The README for https://github.com/openzipkin/brave just talks about "Brave" and "Zipkin". The bom describes itself as "Bill Of Materials POM for all Brave artifacts". I'm leaning towards "Brave".
There was a problem hiding this comment.
Brave sounds good!
wilkinsona
added
type: task
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Oct 6, 2022
wilkinsona
added a commit
that referenced
this pull request
Oct 6, 2022
|
Thanks, @marcingrzejszczak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zipkin dependencies will come via Zipkin BOM