Skip to content

Use Brave BOM instead of only managing a single Zipkin dependency #32614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use Brave BOM instead of only managing a single Zipkin dependency #32614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spring-boot-project/spring-boot-dependencies/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1642,10 +1642,10 @@ bom {
]
}
}
library("Zipkin", "2.16.3") {
group("io.zipkin.reporter2") {
modules = [
"zipkin-sender-urlconnection"
library("Zipkin", "5.14.1") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename this. Perhaps "Zipkin Brave" or just "Brave". What would you recommend?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenZipkin Brave would be most correct I guess (https://github.com/openzipkin/brave).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't seem to use "Open Zipkin" anywhere really though. The README for https://github.com/openzipkin/brave just talks about "Brave" and "Zipkin". The bom describes itself as "Bill Of Materials POM for all Brave artifacts". I'm leaning towards "Brave".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brave sounds good!

group("io.zipkin.brave") {
imports = [
"brave-bom"
]
}
}
Expand Down