-
Notifications
You must be signed in to change notification settings - Fork 13
Make cephadm_key module stateless #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably need some changelog entry that generate_secret and fetch_initial_keys are not a thing anymore
f4ff75a
to
5de4180
Compare
Thanks @mnasiadka - updated the changelog and role docs. I'm not sure |
5cbb0e7
to
5b7bda3
Compare
This module should never write to files because they always exist inside the cephadm container, which is ephemeral. Remove all file-writing functions and references to keyrings.
Co-authored-by: Alex-Welsh <[email protected]>
I took the liberty of rebasing this |
5b7bda3
to
96df029
Compare
Ideally needs a version bump in |
This module should never write to files because they always exist inside the cephadm container, which
is ephemeral. This change removes all file-writing functions and references to keyrings.
This fixes the following failure:
Which is caused by
module.set_fs_attributes_if_different
running on the host when the keyring file is created in a previous step in an ephemeral cephadm container, and no longer exists.This fixes a long-standing idempotency issue, where ceph keys can be created but the module fails on subsequent invocations. A side-effect of this change: the ability to specify and generate a secret string has been removed, and users should rely on retrieving the secret key from the cluster directly by registering the output from
cephadm_key
tasks.