Install ovmf on Ubuntu when EFI VM is requested #99
Conversation
mnasiadka
force-pushed
the
ubuntu_ovmf
branch
2 times, most recently
from
31b5909 to
d0c1b90
Compare
| vars: | ||
| is_efi: >- | ||
| (libvirt_vms | selectattr('state', 'defined') | ||
| | selectattr('state', 'equalto', 'absent') | |
There was a problem hiding this comment.
I just copy pasted the from L14, but you're right - we don't need to install ovmf if we only want to remove VMs (I would assume it's already installed then).
There was a problem hiding this comment.
It's a bit tricky also because the default for state is present, but the first selectattr only looks for VMs with a state defined. I think you'd need to concatenate lists of state undefined and state = present. Or you could ignore this micro optimisation for the state.
| is_efi: >- | ||
| (libvirt_vms | selectattr('state', 'defined') | ||
| | selectattr('state', 'equalto', 'absent') | | ||
| | selectattr('boot_firmware', 'equalto', 'efi')) | bool |
There was a problem hiding this comment.
Will this fail if boot_firmware is not defined for a VM? Based on L58 it should be optional.
There was a problem hiding this comment.
It hasn't failed in Gerrit change - https://review.opendev.org/c/openstack/kayobe/+/921660
There was a problem hiding this comment.
That's because that change sets boot_firmware :)
There was a problem hiding this comment.
Right, a lot of | default(something) ;-)
No description provided.