Install ovmf on Ubuntu when EFI VM is requested #99
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,9 +16,17 @@ | |
| | selectattr('state', 'equalto', 'absent') | list) != libvirt_vms | ||
|
|
||
| # Libvirt requires qemu-img to create qcow2 files. | ||
| - name: Ensure qemu-img and ovmf is installed | ||
| vars: | ||
| is_efi: >- | ||
| (libvirt_vms | selectattr('state', 'defined') | ||
| | selectattr('state', 'equalto', 'absent') | | ||
| | selectattr('boot_firmware', 'equalto', 'efi')) | bool | ||
|
There was a problem hiding this comment. Will this fail if boot_firmware is not defined for a VM? Based on L58 it should be optional. There was a problem hiding this comment. It hasn't failed in Gerrit change - https://review.opendev.org/c/openstack/kayobe/+/921660 There was a problem hiding this comment. That's because that change sets boot_firmware :) There was a problem hiding this comment. Right, a lot of | default(something) ;-) |
||
| packages: | ||
| - "{{ 'qemu-img' if ansible_facts.os_family == 'RedHat' else 'qemu-utils' }}" | ||
| - "{{ 'ovmf' if ansible_facts.os_family == 'Debian' and is_efi }}" | ||
| ansible.builtin.package: | ||
| name: "{{ packages | select | unique | list }}" | ||
| update_cache: "{{ True if ansible_facts.pkg_mgr == 'apt' else omit }}" | ||
| become: true | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be rejectattr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copy pasted the from L14, but you're right - we don't need to install ovmf if we only want to remove VMs (I would assume it's already installed then).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit tricky also because the default for
stateispresent, but the first selectattr only looks for VMs with a state defined. I think you'd need to concatenate lists of state undefined and state = present. Or you could ignore this micro optimisation for the state.