Fix opensearch grafana plugin at last working version #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the query type to "lucene" to fix the `Slurm jobs` dashboard. The original query causes a `SIGSEGV: segmentation violation` in versions above 2.6.2 of the OpenSearch plugin due to this change: grafana/opensearch-datasource@24fcd47#diff-804a5756e358074cb0ba27b1932cca77d39b90694fc1d4d122f46348c8653259 This then makes Grafana return a 500 error with the `TypeError: pa[t] is undefined` message. CC: #292
mkarpiarz
pushed a commit
to mkarpiarz/ansible-slurm-appliance
that referenced
this pull request
Aug 1, 2023
Set the query type to "lucene" to fix the `Slurm jobs` dashboard. The original query causes a `SIGSEGV: segmentation violation` in versions above 2.6.2 of the OpenSearch plugin due to this change: grafana/opensearch-datasource@24fcd47#diff-804a5756e358074cb0ba27b1932cca77d39b90694fc1d4d122f46348c8653259 This then makes Grafana return a 500 error with the `TypeError: pa[t] is undefined` message. CC: stackhpc#292
mkarpiarz
pushed a commit
to mkarpiarz/ansible-slurm-appliance
that referenced
this pull request
Aug 1, 2023
Set the query type to "lucene" to fix the `Slurm jobs` dashboard. The original query causes a `SIGSEGV: segmentation violation` in versions above 2.6.2 of the OpenSearch plugin due to this change: grafana/opensearch-datasource@24fcd47#diff-804a5756e358074cb0ba27b1932cca77d39b90694fc1d4d122f46348c8653259 This then makes Grafana return a 500 error with the `TypeError: pa[t] is undefined` message. CC: stackhpc#292
Fix query type in the Slurm jobs Grafana dashboard
This should mean that existing Grafanas pick up the fix to this provisioned dashboard
|
Cancelled CI as requires #294 to merge first before CI will complete |
m-bull
requested changes
Aug 4, 2023
Use Python3.9 for jupyter notebook server
|
@ af1c633, confirmed slurm jobs dashboard works.
|
m-bull
approved these changes
Aug 4, 2023
This was referenced Aug 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR the grafana plugin installed on a new deployment passes the GUI "test" button but can't actually talk to opensearch. Grafana returns a 500 error and the relevant tile in explore mode shows a JS trace containing
TypeError: pa[t] is undefined.Matt A worked out the last working version manually.
This also incorporates #293 to set the query type correctly. As noted there, this is because of changes to how querytype is handled by the plugin.
Note that:
.filesare not plugin names but dicts including e.g. file stats.