Remove support for setting VNIC binding profiles #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnGarbutt
reviewed
Feb 19, 2025
environments/skeleton/{{cookiecutter.environment}}/tofu/node_group/nodes.tf
Outdated
Show resolved
Hide resolved
sjpb
requested changes
Feb 19, 2025
There was a problem hiding this comment.
According to @JohnGarbutt setting binding profiles is never required now, so we should just remove the profile definition entirely. Note that in addition to the node_group ports there are also ports defined in the control.tf file.
priteau
force-pushed
the
binding-profile
branch
from
d620adf to
f425151
Compare
priteau
changed the title
priteau
force-pushed
the
binding-profile
branch
from
f425151 to
71b910d
Compare
This should not be required anymore and resolves an issue where, after creating a Neutron port of baremetal VNIC type, OpenTofu wants to revert its profile to an empty dict even though it was populated with local_link_information.
priteau
force-pushed
the
binding-profile
branch
from
71b910d to
9f561fd
Compare
JohnGarbutt
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be required anymore and resolves an issue where, after creating a Neutron port of
baremetalVNIC type, OpenTofu wants to revert its profile to an empty dict even though it was populated withlocal_link_information.