2024.1: 2023.1 merge #1266
Merged
2024.1: 2023.1 merge #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2023.1: zed merge
zed: yoga merge
Initally `pre-commit` hooks were installed due the presense of a hook for `control host bootstrap` and when `enable_pre_commit_hooks` was set to `true`. However now `pre-commit` hooks are only installed when the hook is present or the playbook is called, no requirement for an `Ansible` conditional to be true.
Explicitly set rabbit flags for MN-CI upgrades
The job runs nightly at 2:42 AM and runs a test of a randomly selected test scenario from a list of supported combinations. Note that scheduled workflows must live in the default branch of the repository.
CI: Add a periodic multinode job
This includes fixes for breaking, terraform destroy retries, and support for slack alerts.
…iodic.yml Aligns better with friendly name of the workflow.
CI: Only run nightly multinode job in stackhpc repo
Previously we provided an additional file, globals-tls-config.yml, which would be appended to globals.yml at an appropriate point during multinode deployment. This could result in a merge conflict, which cannot be resolved by an automated process such as a GitHub Actions workflow. This change adds the TLS config to globals.yml conditionally, based on whether internal TLS is enabled. We are not removing globals-tls-config.yml for now, since it is used in the terraform-kayobe-multinode repo as a proxy for internal TLS support. The file has already been removed in the Antelope branch.
Allows up to run the intermediary RabbitMQ version upgrades before a SLURP upgrade to Caracal.
Bump RMQ tag for multiple versions
The bug fix we were using in our fork was backported upstream [1]. [1] https://review.opendev.org/c/openstack/ovn-octavia-provider/+/926715
Revert to upstream ovn-octavia-provider
I've commonly hit this when configuring prometheus:
```
TASK [prometheus : Get container facts] *************************************************************************************************************************************
Monday 24 June 2024 11:09:37 +0000 (0:00:08.528) 0:01:31.707 ***********
fatal: [will-compute-01]: FAILED! => changed=false
module_stderr: ''
module_stdout: ''
msg: |-
MODULE FAILURE
See stdout/stderr for the exact error
rc: -13
fatal: [will-compute-02]: FAILED! => changed=false
module_stderr: ''
module_stdout: ''
msg: |-
MODULE FAILURE
See stdout/stderr for the exact error
rc: -13
```
The ControlPersist workaround is documented in these bug reports:
- ansible/ansible#78344
- ansible/ansible#81777
From the comments, It seems like this does not completely resolve the
issue, but does decrease the frequency that you hit this.
The Prometheus tasks seem particuarly susceptible as they run on
every host.
(cherry picked from commit 699769c)
yoga: Backport Add workaround for rc: -13 (#1108)
Alex-Welsh
requested changes
Sep 6, 2024
This reverts commit 901c0c2. This is not required in Caracal.
Alex-Welsh
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install-pre-commit-hooksplaybookpre-commitwithgitinstall-pre-commit-hooksopt-inpre-commithooks are installedpre-commit hookspre-committo contributor docspre-commit installif package is installed or updatedpre_commitversionpre-commitwithoutkayobe-venv