Skip to content

Change default Ceph release to Quincy #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

priteau
Copy link
Member

@priteau priteau commented Apr 13, 2023

No description provided.

@priteau priteau requested a review from a team as a code owner April 13, 2023 12:07
@priteau priteau self-assigned this Apr 13, 2023
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern here is the potential for surprise upgrades.

@priteau
Copy link
Member Author

priteau commented Apr 13, 2023

My main concern here is the potential for surprise upgrades.

Do you prefer to wait until we have a zed branch?

@markgoddard
Copy link
Contributor

My main concern here is the potential for surprise upgrades.

Do you prefer to wait until we have a zed branch?

Let's discuss in today's infra meeting, but that might be safer. Deployments can always make these changes in their branches.

@markgoddard
Copy link
Contributor

I think we agreed to stay on pacific for now

@mnasiadka
Copy link
Member

@markgoddard
Copy link
Contributor

Pacific is EOL-ish - https://github.com/ceph/ceph/blob/main/doc/releases/releases.yml

Yes. I'm not saying we shouldn't update clients to Quincy, but should we make such changes on a stable branch?

@mnasiadka
Copy link
Member

In this case it probably is not problematic (you would need to run bootstrap against a running cluster to make some serious problems), but I understand where you're going - I don't know even if we should have a default in s-k-c.

@markgoddard
Copy link
Contributor

In this case it probably is not problematic (you would need to run bootstrap against a running cluster to make some serious problems), but I understand where you're going - I don't know even if we should have a default in s-k-c.

If we don't have a default in s-k-c then we depend on the default in the collection, which is less visible. We do specify the container image tag in s-k-c too, which is tied to the release

@mnasiadka
Copy link
Member

So let's just assume we just update the default once, in the early stages of a branch - and that's it.

@markgoddard
Copy link
Contributor

Perhaps we should better document how to change the release in SKC docs?

@Alex-Welsh
Copy link
Member

Is it time to close this PR @priteau @markgoddard?

@priteau
Copy link
Member Author

priteau commented Oct 20, 2023

Is it time to close this PR @priteau @markgoddard?

Should I target it to zed instead?

@Alex-Welsh
Copy link
Member

Is it time to close this PR @priteau @markgoddard?

Should I target it to zed instead?

It's already done: https://github.com/stackhpc/stackhpc-kayobe-config/blob/stackhpc/zed/etc/kayobe/cephadm.yml

@priteau
Copy link
Member Author

priteau commented Oct 20, 2023

Not required anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants