Add Cephadm version conditon for Rocky multi-node #824
Conversation
seunghun1ee
added
bug
| @@ -2,6 +2,12 @@ | |||
| ############################################################################### | |||
| # Cephadm deployment configuration. | |||
|
|
|||
| # Ceph release name. | |||
| cephadm_ceph_release: "{{ 'quincy' if (ansible_facts['distribution_release'] == 'jammy') or (ansible_facts['distribution_release'] == '9') else 'pacific' }}" | |||
There was a problem hiding this comment.
Should it go in the main etc/kayobe/cephadm.yml file?
There was a problem hiding this comment.
I'd say the reasoning on not having a surprise upgrade at a client site still stands: #480
There was a problem hiding this comment.
Sure, not saying we should change the default to quincy, but if pacific doesn't work on RL9 then we could conditionally enable it as we are here?
There was a problem hiding this comment.
I moved these conditions to etc/kayobe/cephadm.yml
| @@ -0,0 +1 @@ | |||
| dnf_custom_repos: "{{ stackhpc_dnf_repos }}" | |||
There was a problem hiding this comment.
| dnf_custom_repos: "{{ stackhpc_dnf_repos }}" | |
| --- | |
| dnf_custom_repos: "{{ stackhpc_dnf_repos }}" | |
There was a problem hiding this comment.
Or perhaps copy etc/kayobe/inventory/group_vars/overcloud/stackhpc-dnf-repos to etc/kayobe/environments/ci-multinode/inventory/group_vars/all/stackhpc-dnf-repos
This would also include infra-vms but I don't think that's a bad thing
There was a problem hiding this comment.
I'm not sure that we want this on the seed-hypervisor, as this would be less representative of a customer deployment.
There was a problem hiding this comment.
For a typical deployment there is a chicken and egg situation here because pulp runs on the seed. I agree that multinodes should reflect the standard config.
There was a problem hiding this comment.
What are we going to do here then? Why was this config necessary?
There was a problem hiding this comment.
This config was necessary to ensure RL 9.3 packages to be installed on seed when performing kayobe seed host configure
|
Closing this PR as this change is included on PR #828 |
Add condition of checking Rocky Linux release number on conditional variables
cephadm_ceph_releaseandcephadm_image_tagThe upstream Cephadm Pacific repository is no more available and this change prevents targeting the repository when building Rocky Linux 9 multi-node environment.
The change was made at
etc/kayobe/environments/ci-multinode/cephadm.ymlto override only when environment is set to be ci-multinode