Skip to content

Add Cephadm version conditon for Rocky multi-node #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions etc/kayobe/cephadm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Cephadm deployment configuration.

# Ceph release name.
cephadm_ceph_release: "{{ 'quincy' if (ansible_facts['distribution_release'] == 'jammy') else 'pacific' }}"
cephadm_ceph_release: "{{ 'quincy' if (ansible_facts['distribution_release'] == 'jammy') or (ansible_facts['distribution_release'] == '9') else 'pacific' }}"

# Ceph FSID.
#cephadm_fsid:
Expand All @@ -12,7 +12,7 @@ cephadm_ceph_release: "{{ 'quincy' if (ansible_facts['distribution_release'] ==
cephadm_image: "{{ stackhpc_docker_registry if stackhpc_sync_ceph_images | bool else 'quay.io' }}/ceph/ceph:{{ cephadm_image_tag }}"

# Ceph container image tag.
cephadm_image_tag: "{{ 'v17.2.7' if os_release == 'jammy' else 'v16.2.14' }}"
cephadm_image_tag: "{{ 'v17.2.7' if (os_release == 'jammy') or (os_release == '9') else 'v16.2.14' }}"

# Ceph custom repo workaround for Ubuntu Jammy as there are no official ceph repos for jammy.
cephadm_custom_repos: "{{ ansible_facts['distribution_release'] == 'jammy' }}"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dnf_custom_repos: "{{ stackhpc_dnf_repos }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dnf_custom_repos: "{{ stackhpc_dnf_repos }}"
---
dnf_custom_repos: "{{ stackhpc_dnf_repos }}"

Copy link
Member

@Alex-Welsh Alex-Welsh Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps copy etc/kayobe/inventory/group_vars/overcloud/stackhpc-dnf-repos to etc/kayobe/environments/ci-multinode/inventory/group_vars/all/stackhpc-dnf-repos
This would also include infra-vms but I don't think that's a bad thing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that we want this on the seed-hypervisor, as this would be less representative of a customer deployment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a typical deployment there is a chicken and egg situation here because pulp runs on the seed. I agree that multinodes should reflect the standard config.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we going to do here then? Why was this config necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config was necessary to ensure RL 9.3 packages to be installed on seed when performing kayobe seed host configure