Skip to content

zed: small fixes #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 27, 2023
Merged

zed: small fixes #626

merged 10 commits into from
Sep 27, 2023

Conversation

markgoddard
Copy link
Contributor

@markgoddard markgoddard commented Sep 7, 2023 •
edited
Loading

  • CI: Only sync new images after build
  • swap: Note that Kayobe supports swap in Zed
  • tempest: update max microversions for Cinder & Nova
  • Update stackhpc.pulp to 0.5.2
  • ceph: remove unnecesary Jinja braces
  • aufn-ceph: Use stackhpc/zed branch in script
  • requirements.txt: drop version specifier
  • pulp: Stop syncing prometheus-jiralert image
  • aufn-ceph: Drop cephadm_image override
  • aufn-ceph: Sync inventory with kolla-ansible

@markgoddard markgoddard self-assigned this Sep 7, 2023
markgoddard
markgoddard commented Sep 7, 2023
View reviewed changes
markgoddard
markgoddard commented Sep 7, 2023
View reviewed changes
markgoddard
markgoddard commented Sep 7, 2023
View reviewed changes
etc/kayobe/kolla.yml Outdated
@@ -331,14 +332,8 @@ kolla_build_customizations: "{{ kolla_build_customizations_common | combine(koll

# Dict mapping Kolla Dockerfile ARG names to their values.
kolla_build_args:
blackbox_exporter_version: "0.19.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will need a rebuild & tag update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/6174749103

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying again... https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/6174929742

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu builds failing :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test pulp is having issues. It failed on apt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is that just the standard ubuntu repos getting out of sync issue? Will has a PR for yoga to bump the snapshot versions.

Alex-Welsh
Alex-Welsh reviewed Sep 7, 2023
View reviewed changes
@markgoddard markgoddard marked this pull request as ready for review September 13, 2023 15:38
@markgoddard markgoddard requested a review from a team as a code owner September 13, 2023 15:38
@markgoddard markgoddard changed the title zed bits zed: small fixes Sep 13, 2023
Alex-Welsh
Alex-Welsh reviewed Sep 13, 2023
View reviewed changes
@markgoddard markgoddard mentioned this pull request Sep 14, 2023
Closed
Alex-Welsh
Alex-Welsh reviewed Sep 14, 2023
View reviewed changes
@Alex-Welsh
Copy link
Member

Might also be a good time to bump the pulp container a bit?

@markgoddard
Copy link
Contributor Author

Might also be a good time to bump the pulp container a bit?

Could be, but needs testing.

@Alex-Welsh
Copy link
Member

cephadm_image in aufn-ceph/cephadm.yml needs updating

@markgoddard
Copy link
Contributor Author

cephadm_image in aufn-ceph/cephadm.yml needs updating

I removed it since the default should now work.

@markgoddard
CI: Allow logging of Rally/Tempest
8384dc4 
By default the 'Run tempest' task has no_log set to avoid revealing
sensitive data. This does not apply in CI, and makes it difficult to
debug failures.
@Alex-Welsh
Copy link
Member

Do you want more suggestions for things that need to change but are not included on this PR, or should we just try to get this through with the changes that are in at the moment?

@Alex-Welsh
Copy link
Member

Do you want more suggestions for things that need to change but are not included on this PR, or should we just try to get this through with the changes that are in at the moment?

i.e. we need to change https://github.com/stackhpc/stackhpc-kayobe-config/blob/stackhpc/zed/.github/workflows/stackhpc-build-kayobe-image.yml#L70C12-L70C12 at some point to include BASE_IMAGE: rockylinux:9. There's also some references to virtualenv in the aufn deployment script that should be swapped for python3 -m venv

@markgoddard
Copy link
Contributor Author

Do you want more suggestions for things that need to change but are not included on this PR, or should we just try to get this through with the changes that are in at the moment?

i.e. we need to change https://github.com/stackhpc/stackhpc-kayobe-config/blob/stackhpc/zed/.github/workflows/stackhpc-build-kayobe-image.yml#L70C12-L70C12 at some point to include BASE_IMAGE: rockylinux:9. There's also some references to virtualenv in the aufn deployment script that should be swapped for python3 -m venv

Mostly looking for a +1/-1 on these changes. Unless there are issues with these or related things I'd prefer to get this one merged and make tickets in Jira for outstanding issues.

@markgoddard markgoddard merged commit 18edfec into stackhpc/zed Sep 27, 2023
@markgoddard markgoddard deleted the zed-bits branch September 27, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Welsh Alex-Welsh Alex-Welsh approved these changes

Assignees

@markgoddard markgoddard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markgoddard @Alex-Welsh