-
Notifications
You must be signed in to change notification settings - Fork 23
Allow resolv.conf to be managed for Ubuntu AIO #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Solved in #854 for CI Turns out DNS config wasn't being applied as networkd config was being set for ens3 rather than enp3s0. Still broken for manual deployment AFAIK. |
Should this PR be closed? |
Why is it broken in a manual deployment? |
networkd configuration for enp3s0 isn't being templated in when deploying manually via the automated script, hence the need for resolv.conf to be managed by Kayobe in these cases as DNS breaks when the device is left unmanaged. |
I have now hit this in an Ubuntu VM and can see the issue you're trying to address. |
# Don't touch resolv.conf: use Neutron DNS for accessing Pulp server via | ||
# hostname. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't actually make use of this - we write out an entry in /etc/hosts. I suggest we just remove all of this config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify do you mean remove the resolv config entirely or just remove the hostname resolv_domain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove everything in this Network configuration
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll close this one and make a pr.
Continued in #920 |
Fix Ubuntu AIOs in CI by allowing resolv.conf to be managed by Kayobe.