Skip to content

Allow resolv.conf to be managed for Ubuntu AIO #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

assumptionsandg
Copy link
Contributor

Fix Ubuntu AIOs in CI by allowing resolv.conf to be managed by Kayobe.

@assumptionsandg assumptionsandg requested a review from a team as a code owner December 22, 2023 12:10
@assumptionsandg
Copy link
Contributor Author

assumptionsandg commented Dec 22, 2023

Solved in #854 for CI

Turns out DNS config wasn't being applied as networkd config was being set for ens3 rather than enp3s0. Still broken for manual deployment AFAIK.

@markgoddard
Copy link
Contributor

Should this PR be closed?

@markgoddard
Copy link
Contributor

Solved in #854 for CI

Turns out DNS config wasn't being applied as networkd config was being set for ens3 rather than enp3s0. Still broken for manual deployment AFAIK.

Why is it broken in a manual deployment?

@assumptionsandg
Copy link
Contributor Author

Solved in #854 for CI
Turns out DNS config wasn't being applied as networkd config was being set for ens3 rather than enp3s0. Still broken for manual deployment AFAIK.

Why is it broken in a manual deployment?

networkd configuration for enp3s0 isn't being templated in when deploying manually via the automated script, hence the need for resolv.conf to be managed by Kayobe in these cases as DNS breaks when the device is left unmanaged.

@markgoddard
Copy link
Contributor

I have now hit this in an Ubuntu VM and can see the issue you're trying to address.

Comment on lines -11 to -12
# Don't touch resolv.conf: use Neutron DNS for accessing Pulp server via
# hostname.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't actually make use of this - we write out an entry in /etc/hosts. I suggest we just remove all of this config.

Copy link
Contributor Author

@assumptionsandg assumptionsandg Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify do you mean remove the resolv config entirely or just remove the hostname resolv_domain?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove everything in this Network configuration section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll close this one and make a pr.

@assumptionsandg
Copy link
Contributor Author

Continued in #920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants