Skip to content

Allow resolv.conf to be managed for Ubuntu AIO #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow resolv.conf to be managed for Ubuntu AIO #853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions etc/kayobe/environments/ci-aio/stackhpc-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ kolla_docker_namespace: stackhpc-dev
###############################################################################
# Network configuration.

# Don't touch resolv.conf: use Neutron DNS for accessing Pulp server via
# hostname.
Comment on lines -11 to -12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't actually make use of this - we write out an entry in /etc/hosts. I suggest we just remove all of this config.

Copy link
Contributor Author

@assumptionsandg assumptionsandg Feb 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify do you mean remove the resolv config entirely or just remove the hostname resolv_domain?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove everything in this Network configuration section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll close this one and make a pr.

resolv_is_managed: false
# Allow resolv.conf to be managed for Ubuntu
resolv_is_managed: "{{ os_distribution == 'ubuntu' }}"
resolv_nameservers: [ "8.8.8.8", "8.8.4.4" ]
resolv_domain: "internal.sms-cloud"

###############################################################################
# StackHPC configuration.
Expand Down