Support RabbitMQ minor version upgrades and Quorum migration #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
reviewed
Sep 11, 2024
| @@ -89,6 +89,18 @@ | |||
| vars: | |||
| kayobe_environment_path: "{{ src_directory }}/kayobe-config/etc/kayobe/environments/{{ kayobe_config_environment }}" | |||
|
|
|||
| - name: Revert RabbitMQ changes to avoid git conflicts (upgrade) | |||
There was a problem hiding this comment.
This stuff gets a bit fiddly, and brittle when considering support for multiple releases. Longer term it probably needs a different solution, like writing the config overrides to a specific file that can be deleted on upgrade.
| - name: Revert RabbitMQ changes to avoid git conflicts (upgrade) | ||
| ansible.builtin.shell: | ||
| cmd: >- | ||
| if grep "om_enable_rabbitmq_high_availability: false" {{ kayobe_environment_path }}/kolla/globals.yml ; then |
There was a problem hiding this comment.
Does this do the right thing for:
- yoga -> zed
- zed -> antelope
- antelope -> caracal (hopefully yes)
- caracal -> epoxy
(bearing in mind SKC may change over time...)
| @@ -336,6 +336,27 @@ function upgrade_overcloud() { | |||
| kayobe overcloud service upgrade | |||
| } | |||
|
|
|||
| function rabbit_migration() { | |||
| # Ensure RabbitMQ is upgraded to 3.13 | |||
| if kayobe overcloud host command run -l controllers -b --command "docker exec rabbitmq rabbitmqctl --version | grep 3.11" --show-output; then | |||
There was a problem hiding this comment.
nit: It shouldn't be an issue here, but you need to be careful with . in grep
MoteHue
reviewed
Sep 11, 2024
| @@ -336,6 +336,27 @@ function upgrade_overcloud() { | |||
| kayobe overcloud service upgrade | |||
| } | |||
|
|
|||
| function rabbit_migration() { | |||
| # Ensure RabbitMQ is upgraded to 3.13 | |||
| if kayobe overcloud host command run -l controllers -b --command "docker exec rabbitmq rabbitmqctl --version | grep 3.11" --show-output; then | |||
There was a problem hiding this comment.
It's not an issue right now, but RabbitMQ versions are split into three: e.g. 3.13.7. there is a chance they'll go all the way up to 3.13.11, which would also get caught by this grep
|
Superseded by #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new command -
rabbit_migrationto execute a RabbitMQ minor version upgrade and Quorum queue migration. Required for Antelope->Caracal upgrades