Skip to content

Add upgrade_prerequisites function #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

Alex-Welsh
Copy link
Member

@Alex-Welsh Alex-Welsh commented Sep 27, 2024

Supersedes #72

Adds a generic function to run an "upgrade-prerequisites" script if it exists, so each release can perform its own pre-upgrade actions.

@Alex-Welsh
Copy link
Member Author

See also stackhpc/stackhpc-kayobe-config#1308

@seunghun1ee
Copy link
Member

Looks good

@Alex-Welsh Alex-Welsh marked this pull request as ready for review October 4, 2024 14:22
@Alex-Welsh Alex-Welsh requested a review from a team as a code owner October 4, 2024 14:22
@Alex-Welsh Alex-Welsh force-pushed the upgrade-prerequisites branch from 7d69499 to ac36fa3 Compare October 8, 2024 12:04
@Alex-Welsh
Copy link
Member Author

Reverted volume type change since it is unrelated

seunghun1ee
seunghun1ee previously approved these changes Oct 10, 2024
Copy link
Contributor

@MoteHue MoteHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers

@Alex-Welsh Alex-Welsh merged commit fb34399 into main Oct 10, 2024
@Alex-Welsh Alex-Welsh deleted the upgrade-prerequisites branch October 10, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants