Consolidate icons #1302
Merged
Consolidate icons #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
So much happier with this — as well as deduplicating stuff it fixes a few rough edges around colours not being switched in dark mode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been meaning to do this for a while — we can deduplicate various icon files across the repo by having a dedicated
iconspackage that servesapps/*andpackages/*.By using CSS masks we can also avoid the need to have separate light and dark variants.
I'm doing this now because some upcoming work will involve adding a bunch more icons and I'd like to be able to change colours on hover; if I don't do it soon it will create a whole bunch of extra work