Skip to content

Consolidate icons #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/svelte.dev/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"do-not-zip": "^1.0.0",
"flexsearch": "^0.7.43",
"flru": "^1.0.2",
"icons": "workspace:*",
"port-authority": "^2.0.1",
"topojson-client": "^3.1.0",
"vitest": "^2.1.9",
Expand Down
11 changes: 0 additions & 11 deletions apps/svelte.dev/src/lib/icons/arrow-left.svg

This file was deleted.

3 changes: 0 additions & 3 deletions apps/svelte.dev/src/lib/icons/bluesky-dark.svg

This file was deleted.

3 changes: 0 additions & 3 deletions apps/svelte.dev/src/lib/icons/chevron.svg

This file was deleted.

29 changes: 0 additions & 29 deletions apps/svelte.dev/src/lib/icons/contents.svg

This file was deleted.

1 change: 0 additions & 1 deletion apps/svelte.dev/src/lib/icons/discord-dark.svg

This file was deleted.

1 change: 0 additions & 1 deletion apps/svelte.dev/src/lib/icons/download-dark.svg

This file was deleted.

1 change: 0 additions & 1 deletion apps/svelte.dev/src/lib/icons/download-light.svg

This file was deleted.

3 changes: 0 additions & 3 deletions apps/svelte.dev/src/lib/icons/external.svg

This file was deleted.

3 changes: 0 additions & 3 deletions apps/svelte.dev/src/lib/icons/file-dark.svg

This file was deleted.

3 changes: 0 additions & 3 deletions apps/svelte.dev/src/lib/icons/file-edit-inline-dark.svg

This file was deleted.

3 changes: 0 additions & 3 deletions apps/svelte.dev/src/lib/icons/file-edit.svg

This file was deleted.

3 changes: 0 additions & 3 deletions apps/svelte.dev/src/lib/icons/file.svg

This file was deleted.

1 change: 0 additions & 1 deletion apps/svelte.dev/src/lib/icons/github-dark.svg

This file was deleted.

1 change: 0 additions & 1 deletion apps/svelte.dev/src/lib/icons/lightbulb.svg

This file was deleted.

7 changes: 0 additions & 7 deletions apps/svelte.dev/src/lib/icons/terminal.svg

This file was deleted.

1 change: 0 additions & 1 deletion apps/svelte.dev/src/lib/icons/user-dark.svg

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -272,12 +272,15 @@

&.login {
width: auto;
background-image: url($lib/icons/user-light.svg);
background-position: 0.4rem 50%;
padding: 0 0.4rem 0 2.8rem;

:root.dark & {
background-image: url($lib/icons/user-dark.svg);
padding: 0 0.4rem;

&::before {
content: '';
width: 1.8rem;
height: 1.8rem;
margin: 0 0.5rem 0 0;
background: currentColor;
mask: url(icons/user) no-repeat 50% 50%;
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions apps/svelte.dev/src/routes/_home/Video.svelte
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<script lang="ts">
import volume_off from './volume-off.svg';
import volume_high from './volume-high.svg';
import cc_on from './cc-on.svg';
import cc_off from './cc-off.svg';
import play from './play.svg';
import pause from './pause.svg';
import volume_off from 'icons/volume-off';
import volume_high from 'icons/volume-high';
import cc_on from 'icons/cc-on';
import cc_off from 'icons/cc-off';
import play from 'icons/play';
import pause from 'icons/pause';
import vtt from './subtitles.vtt';
import { onMount } from 'svelte';

Expand Down
22 changes: 0 additions & 22 deletions apps/svelte.dev/src/routes/_home/cc-off.svg

This file was deleted.

14 changes: 0 additions & 14 deletions apps/svelte.dev/src/routes/_home/cc-on.svg

This file was deleted.

11 changes: 0 additions & 11 deletions apps/svelte.dev/src/routes/_home/plus.svg

This file was deleted.

11 changes: 0 additions & 11 deletions apps/svelte.dev/src/routes/_home/up-small.svg

This file was deleted.

21 changes: 16 additions & 5 deletions apps/svelte.dev/src/routes/docs/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,24 @@
}

h2 {
position: relative;
padding-right: 4rem;
background: url(./arrow-right.svg) no-repeat 100% 50%;
background-size: 3rem;

.external & {
background-image: url(./external-link.svg);
background-size: 3rem;
&::after {
content: '';
position: absolute;
width: 3rem;
height: 3rem;
top: 0.2rem;
right: 0;

background: var(--sk-fg-accent);
mask: url(icons/arrow-right) no-repeat 100% 50%;
mask-size: 100%;
}

.external &::after {
mask-image: url(icons/external-link);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
position: relative;
display: flex;
align-items: center;
background: url($lib/icons/contents.svg) 0 50% no-repeat;
background: url(icons/contents) 0 50% no-repeat;
background-size: 2rem 2rem;
padding: 0.2rem 0 0 3rem;
height: 3rem;
Expand Down Expand Up @@ -133,11 +133,12 @@
}

&::after {
background: url($lib/icons/chevron.svg) 50% 50% no-repeat;
background-size: 2rem;
background: currentColor;
mask: url(icons/chevron) 50% 50% no-repeat;
mask-size: 2rem;
top: 0.4rem;
right: 0.2rem;
rotate: 0deg;
rotate: -90deg;
transition: rotate 0.2s;
transition: rotate 0.2s;
}
Expand All @@ -161,7 +162,7 @@

label:has(:checked) {
&::after {
rotate: 180deg;
rotate: 90deg;
}

/* TODO remove :global once https://github.com/sveltejs/svelte/issues/13779 is fixed */
Expand Down
2 changes: 1 addition & 1 deletion apps/svelte.dev/src/routes/search/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
border: none;
border-radius: var(--sk-border-radius);
padding: 2rem 2rem 2rem 5rem;
background: no-repeat 1rem 50% / 3rem 3rem url(/icons/search.svg);
background: no-repeat 1rem 50% / 3rem 3rem url(icons/search);
color: var(--sk-fg-1);
}
</style>
18 changes: 10 additions & 8 deletions apps/svelte.dev/src/routes/tutorial/[...slug]/Chrome.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@

<button
disabled={loading || !toggle_terminal}
class="terminal icon raised"
class="terminal raised"
onclick={() => toggle_terminal?.()}
aria-label="toggle terminal"
></button>
aria-label="toggle terminal"><span class="icon"></span></button
>
</div>

<style>
Expand Down Expand Up @@ -88,23 +88,25 @@

.icon,
.icon::after {
position: relative;
width: 3.2rem;
aspect-ratio: 1;
background-size: 1.8rem;
}

.terminal {
background-image: url($lib/icons/terminal.svg);
.terminal .icon {
background: currentColor;
mask: url(icons/terminal) 50% 50% no-repeat;
mask-size: 1.8rem;
}

.reload::after {
content: '';
position: absolute;
left: 0;
top: 0;
background: url($lib/icons/refresh.svg) no-repeat 50% 50%;
background-size: 1.8rem;
background: currentColor;
mask: url(icons/refresh) no-repeat 50% 50%;
mask-size: 1.8rem;
transition: 0.2s ease-out;
}

Expand Down
27 changes: 11 additions & 16 deletions apps/svelte.dev/src/routes/tutorial/[...slug]/Sidebar.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -122,26 +122,21 @@
[data-file],
.filename {
cursor: pointer;
background-image: url($lib/icons/file.svg);
background-repeat: no-repeat;

:root.dark & {
background-image: url($lib/icons/file-dark.svg);
&::before {
position: relative;
content: '';
display: inline-block;
width: 1rem;
height: 1rem;
top: 0.1rem;
margin-right: 0.5rem;
background: currentColor;
mask: url(icons/file) 50% 50% no-repeat;
mask-size: 100%;
}
}

[data-file] {
background-position: 0.5rem 50%;
background-size: 1rem 1rem;
padding-left: 2rem;
}

.filename {
background-position: 0 54%;
background-size: 1rem 1rem;
padding-left: 1.5rem !important;
}

.desktop {
display: none;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script lang="ts">
import * as context from './context.js';
import Item from './Item.svelte';
import file_icon from '$lib/icons/file.svg';
import file_icon from 'icons/file';
import { solution } from '../state.svelte';
import type { MenuItem } from '$lib/tutorial';
import type { File } from '@sveltejs/repl/workspace';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
import * as context from './context.js';
import { get_depth } from '$lib/utils/path.js';
import Item from './Item.svelte';
import folder_closed from '$lib/icons/folder.svg';
import folder_open from '$lib/icons/folder-open.svg';
import folder_closed from 'icons/folder';
import folder_open from 'icons/folder-open';
import { solution } from '../state.svelte';
import type { MenuItem } from '$lib/tutorial';
import type { Directory, File as IFile, Item as IItem } from '@sveltejs/repl/workspace';
Expand Down
Loading