Skip to content

Single decker nav #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Single decker nav #310

merged 3 commits into from
Oct 9, 2024

Conversation

Rich-Harris
Copy link
Member

After the UI tweaks that go with the new examples menu, I no longer think the double decker nav makes sense — I think this works better, particularly the interaction between the secondary nav and the 'playground' border-bottom.

main

image

this PR

image

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 8:33pm

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this looks nicer

@Rich-Harris Rich-Harris merged commit 0f7fc57 into main Oct 9, 2024
3 checks passed
@Rich-Harris Rich-Harris deleted the nav-groups branch October 9, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants