Skip to content

Single decker nav #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Single decker nav #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa8f153
single decker nav
Rich-Harris Oct 9, 2024
c9a359a
mobile fix
Rich-Harris Oct 9, 2024
31de878
lint
Rich-Harris Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/svelte.dev/src/routes/(authed)/playground/[id]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@
flex-direction: column;

@media (min-width: 800px) {
--app-controls-h: 5rem;
--app-controls-h: 6rem;
}
}

Expand Down
15 changes: 2 additions & 13 deletions apps/svelte.dev/src/routes/(authed)/playground/[id]/AppControls.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,20 +305,8 @@ export default app;`
flex: 0;
gap: 1rem;

&::after {
content: '';
position: absolute;
left: 0;
bottom: -4px;
width: 100%;
height: 4px;
z-index: 2;
background: linear-gradient(to bottom, rgba(0, 0, 0, 0.05), transparent);
}

@media (min-width: 800px) {
padding-top: 0;
padding-bottom: 1rem;
padding-top: 1rem;
}
}

Expand Down Expand Up @@ -383,6 +371,7 @@ export default app;`
border-radius: var(--sk-border-radius);
color: currentColor;
font-family: var(--sk-font-ui);
width: 0;
flex: 1;
padding: 0.2rem 0.6rem;
height: 3.2rem;
Expand Down
6 changes: 1 addition & 5 deletions apps/svelte.dev/src/routes/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,7 @@

<Shell nav_visible={$page.route.id !== '/(authed)/playground/[id]/embed'}>
{#snippet top_nav()}
<Nav
title={data.nav_title}
links={data.nav_links}
shadow={!$page.route.id?.startsWith('/(authed)/playground')}
>
<Nav title={data.nav_title} links={data.nav_links}>
{#snippet search()}
<Search />
{/snippet}
Expand Down
2 changes: 1 addition & 1 deletion packages/repl/src/lib/Repl.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@
width: 100%;
height: calc(100dvh - var(--sk-nav-height));
background: var(--sk-back-1);
padding: 1rem 0 0 0;
padding: 0;

&.embedded {
height: 100%;
Expand Down
6 changes: 2 additions & 4 deletions packages/site-kit/src/lib/nav/Nav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@ Top navigation bar for the application. It provides a slot for the left side, th
links: NavigationLink[];
search?: Snippet;
external_links?: Snippet;
shadow: boolean;
}

let { home_title = 'Homepage', title, links, search, external_links, shadow }: Props = $props();
let { home_title = 'Homepage', title, links, search, external_links }: Props = $props();

let visible = $state(true);

Expand Down Expand Up @@ -67,7 +66,6 @@ Top navigation bar for the application. It provides a slot for the left side, th
class:visible={visible || $nav_open}
class:$nav_open
class:dark={$theme.current === 'dark'}
class:shadow
style:z-index={$overlay_open && ($searching || $on_this_page_open) ? 80 : null}
aria-label="Primary"
>
Expand Down Expand Up @@ -300,7 +298,7 @@ Top navigation bar for the application. It provides a slot for the left side, th
display: grid;
grid-template-columns: auto 1fr 1fr;

&.shadow::after {
&::after {
top: auto;
bottom: -4px;
background: linear-gradient(to bottom, rgba(0, 0, 0, 0.05), transparent);
Expand Down
Loading