chore: apply each block controlled teardown optimization, again #11051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trueadm
commented
Apr 3, 2024
| // TODO: would be good to avoid this closure in the case where we have no | ||
| // transitions at all. It would make it far more JIT friendly in the hot cases. | ||
| pause_effects(to_destroy, () => { | ||
| var controlled_anchor = is_controlled && b_items.length === 0 ? anchor : null; |
There was a problem hiding this comment.
This line had the bug before. We now use b_items.length rather than b, which was a copy bug from the indexed reconcile logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11045 was reverted because it had a bug in it. This fixes that.