Skip to content

fix: always close tags when namespace is foreign #12623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

dummdidumm
Copy link
Member

This was a mixup of the if block logic, we should always close tags in foreign namespace. Doesn't really help with unskipping any tests though, because we have no way of preserving attribute names using the $.template approach (to my knowledge) - we need the DOM creation abstraction API (createElement etc) for that, which will come sometime in 5.x.

Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: 0405c9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit c9e9e90 into main Jul 26, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the foreign-ns-fix branch July 26, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants