Skip to content

fix: always close tags when namespace is foreign #12623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix: always close tags when namespace is foreign #12623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/svelte/src/compiler/phases/3-transform/server/visitors/RegularElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export function RegularElement(node, context) {
);
}

if (!VoidElements.includes(node.name) && namespace !== 'foreign') {
if (!VoidElements.includes(node.name) || namespace === 'foreign') {
state.template.push(b.literal(`</${node.name}>`));
}

Expand Down
4 changes: 3 additions & 1 deletion packages/svelte/tests/runtime-legacy/samples/attribute-casing-foreign-namespace/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { test } from '../../test';

export default test({
skip: true, // TODO: needs fixing
// TODO: needs fixing. Can only be fixed once we also support document.createElementNS-style creation of elements
// because the $.template('...') approach has no option to preserve attribute name casing
skip: true,

html: `
<page horizontalAlignment="center">
Expand Down
Loading