Skip to content

fix: allow combinator at start of nested CSS selector #13440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

dummdidumm
Copy link
Member

Solved by moving the combinator positioning validation into the analysis phase

Fixes #13433

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 29, 2024

🦋 Changeset detected

Latest commit: a14b363

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Solved by moving the combinator positioning validation into the analysis phase

Fixes #13433
@Rich-Harris
Copy link
Member

the test failure is unrelated and currently happens on main — a bad interaction between #13484 and #13456. looking into it

@Rich-Harris Rich-Harris merged commit 5675067 into main Oct 3, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the nested-css-combinator branch October 3, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid selector when nesting a selector beginning with a combinator
2 participants