Skip to content

feat: fix accessors and support migration of accessors #13456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Sep 30, 2024

Svelte 5 rewrite

Closes #13453

This both fixes accessors when defined as exports and implement the migration from a component with <svelte:options accessors /> removing the accessors option and exporting all the props.

I've excluded props because whoever is migrating this component definitely was not accessing slots through accessors and they can always add it by hand if they want.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: de65e1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit c716329 into main Oct 3, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the accessors-migration-and-fix branch October 3, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration: prop accessors are not migrated
3 participants