[BoundsSafety] Parse external bounds attributes in ObjC methods #10068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parses counted_by et. al. for parameters and return types in Objective-C method signatures. No semantic checking is done to ensure that protocol, interface and implementation are aligned. rdar://145190177
hnrklssn
requested review from
delcypher,
rapidsna,
patrykstefanski and
apple-fcloutier
|
@swift-ci please smoke test |
|
@swift-ci please test llvm |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
rapidsna
reviewed
Mar 27, 2025
clang/test/BoundsSafety/AST/objc.m
Outdated
| // CHECK-NEXT: | |-ParmVarDecl {{.*}} len 'int' | ||
| // CHECK-NOT: IsDeref | ||
| // CHECK-NEXT: | | `-DependerDeclsAttr | ||
| // CHECK-NEXT: | `-ParmVarDecl {{.*}} p 'int *{{(__single)?}} __counted_by(len)':'int *{{(__single)?}}' |
There was a problem hiding this comment.
We don't make thin pointers __single in attribute-only modes, so the expected output should be different between the two modes.
By separating the check lines containing implicit __single, we explicitly check that attribute-only mode does not contain any implicit __single attributes, while -fbounds-safety does.
|
@swift-ci please smoke test |
|
@swift-ci please test llvm |
|
@swift-ci please test linux |
|
@swift-ci please test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses counted_by et. al. for parameters and return types in Objective-C method signatures. No semantic checking is done to ensure that protocol, interface and implementation are aligned.
rdar://145190177