[ClangImporter][Swiftify] Add _SwiftifyImportProtocol for safe overloads for protocols #79510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hnrklssn
commented
Feb 20, 2025
hnrklssn
commented
hnrklssn
requested review from
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
a team,
slavapestov,
xedin,
beccadax and
ian-twilightcoder
as code owners
|
This depends on Clang changes in swiftlang/llvm-project#10068 |
Xazax-hun
reviewed
Feb 20, 2025
lib/ClangImporter/ImportDecl.cpp
Outdated
| return false; | ||
|
|
||
| printSeparator(); | ||
| out << ".method(name: \"" << Method->getName().getBaseIdentifier() |
There was a problem hiding this comment.
Will this work for overloaded methods?
There was a problem hiding this comment.
Hmm that's a really good point actually... I'm guessing macros don't have access to mangled names of declarations, otherwise comparing the mangled name instead could work.
There was a problem hiding this comment.
This now passes the entire method signature to disambiguate overloaded methods
The existing _SwiftifyImport macro is a peer macro, limiting it to only emitting function wrappers in the same scope as the original function. Protocols cannot contain function implementations, so these need to be placed in a separate protocol extension instead. _SwiftifyImportProtocol is an extension macro rather than a peer macro, to enable this functionality. Rather than operating on a single function, like _SwiftifyImport, _SwiftifyImportProtocol takes information about multiple methods and creates a single protocol extension with all wrappers in a one-shot operation. rdar://144335990
`registerStdSpanTypeMapping` used to be a lambda inside `swiftify`. By moving it, along with the `typeMapping` state, inside `SwiftifyInfoPrinter` we will simplify changes necessary to support `_SwiftifyImportProtocol` in ClangImporter.
with bounds attributes This creates safe overloads for any methods in the protocol annotated with bounds information. rdar://144335990
To disambiguate overloaded methods in _SwiftifyImportProtocol we now pass the entire function signature instead of just the function name. This should be reflected in the parameter name.
We previously asserted that a variable contained a FileUnit, but the intention of this was to separate it from SourceFiles, and SourceFile is a subtype of FileUnit, so it wouldn't trigger if the variable actually contained a SourceFile.
This was only passed to _SwiftifyImportProtocol, now it is also passed to _SwiftifyImport. This results in @available being attached to generated overloads that use [Mutable][Raw]Span.
Escapable inout parameters don't have an implicit lifetime that can be borrowed or copied, because the caller doesn't know what the lifetime of the new value is, if the callee writes to the parameter. Depending on the lifetime of an Escapable inout parameter without explicit lifetime annotation results in an error, so _SwiftifyImport should not do that.
hnrklssn
force-pushed
the
swiftify-obj-c
branch
from
67daddc to
93e659b
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.