[MergeFuncs] Don't introduce calls to (linkonce,weak)_odr functions. #10112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
fhahn
added a commit
to swiftlang/swift
that referenced
this pull request
Feb 26, 2025
|
Please test with following PR: @swift-ci test |
fhahn
added a commit
to swiftlang/swift
that referenced
this pull request
Feb 26, 2025
|
Please test with following PR: @swift-ci test |
1 similar comment
|
Please test with following PR: @swift-ci test |
fhahn
force-pushed
the
fix-merge-func-link0nce
branch
from
3aa6707 to
6f09417
Compare
|
@swift-ci please test |
Tests for llvm#125050. (cherry picked from commit aa77085)
…lvm#125050) Avoid creating new calls to linkonce_odr/weak_odr functions when merging 2 functions, as this may introduce an infinite call cycle. Consider 2 functions below, both present in 2 modules. Module X -- define linkonce_odr void @"A"() { call void @"foo"() } define linkonce_odr void @"B"() { call void @"foo"() } --- Module Y --- global @"g" = @"B" define linkonce_odr void @"A"() { %l = load @"g" call void %l() } define linkonce_odr void @"B"() { call void @"foo"() } --- @"A" and @"B" in both modules are semantically equivalent Module X after function merging: --- define linkonce_odr void @"A"() { call void @"foo"() } define linkonce_odr void @"B"() { call void @"A"() } --- Module Y is unchanged. Then the linker picks @"A" from module Y and @"B" from module X. Now there's an infinite call cycle PR: llvm#125050 (cherry picked from commit f10e0f7)
fhahn
force-pushed
the
fix-merge-func-link0nce
branch
from
6f09417 to
6f1edfc
Compare
|
Please test with following PR: @swift-ci test |
fhahn
added a commit
to swiftlang/swift
that referenced
this pull request
Mar 6, 2025
|
Please test with following PR: @swift-ci test |
fhahn
added a commit
to swiftlang/swift
that referenced
this pull request
Mar 10, 2025
fhahn
added a commit
to swiftlang/swift
that referenced
this pull request
Mar 13, 2025
|
Please test with following PR: @swift-ci test |
fhahn
added a commit
to swiftlang/swift
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid creating new calls to linkonce_odr/weak_odr functions when
merging 2 functions, as this may introduce an infinite call
cycle.
Consider 2 functions below, both present in 2 modules.
Module X
--
define linkonce_odr void @"A"() {
call void @"foo"()
}
define linkonce_odr void @"B"() {
call void @"foo"()
}
Module Y
global @"g" = @"B"
define linkonce_odr void @"A"() {
%l = load @"g"
call void %l()
}
define linkonce_odr void @"B"() {
call void @"foo"()
}
@"A" and @"B" in both modules are semantically equivalent
Module X after function merging:
define linkonce_odr void @"A"() {
call void @"foo"()
}
define linkonce_odr void @"B"() {
call void @"A"()
}
Module Y is unchanged.
Then the linker picks @"A" from module Y and @"B" from module X. Now there's an infinite call cycle
PR: llvm#125050
(cherry picked from commit f10e0f7)
rdar://143714290