[Test] Use -disable-llvm-merge-function-pass to unblock MergeFunc fix.

[fhahn]

To unblock CI for swiftlang/llvm-project#10112.

[fhahn]

Please test with following PR:
swiftlang/llvm-project#10112

@swift-ci test

[fhahn]

Please test with following PR:
swiftlang/llvm-project#10112

@swift-ci test

[fhahn]

This seems to fail the windows test, but from the log it is not clear to me if this is an issue related to swiftlang/llvm-project#10112?

[compnerd]

It possibly could be. The merge functions would potentially have removed previously invalid IRGen. Unfortunately, it is difficult to tell what is going on without having a dump of the module itself to see what COMDATs are being keyed improperly.

[fhahn]

It possibly could be. The merge functions would potentially have removed previously invalid IRGen. Unfortunately, it is difficult to tell what is going on without having a dump of the module itself to see what COMDATs are being keyed improperly.

@compnerd it looks like this is a Windows-only crash

FAILED: stdlib/public/Concurrency/WINDOWS/x86_64/_Concurrency.obj T:/x86_64-unknown-windows-msvc/Runtime/stdlib/public/Concurrency/WINDOWS/x86_64/_Concurrency.obj 
...
3.	Running pass 'Function Pass Manager' on module 'T:/x86_64-unknown-windows-msvc/Runtime/stdlib/public/Concurrency//WINDOWS/x86_64/_Concurrency.obj'.
4.	Running pass 'X86 Assembly Printer' on function '@78'

Any chance you could help with extracting the IR for that file?

[compnerd]

I'm in middle of a refactoring of the build script, so I cannot get through a complete build atm. Once that is done, I can help. I can help you get setup with a local build though.

[hjyamauchi]

My machines are also busy atm but I will try getting info when I can

[fhahn]

Please test with following PR:
swiftlang/llvm-project#10112

@swift-ci test

[fhahn]

I'm trying to see if I can get the IR by dumping it for the failing tests.

[hjyamauchi]

Any luck?

[compnerd]

Looking at the IR:

<unknown>:0: note: Associative COMDAT symbol '$sShySiGIgo_AAIegr_TR0133$s11Observation0A9RegistrarV5State33_5AE0855755CD62D4521FC18D42BC1E4BLLV16registerTracking3for6didSetSiShys10AnyKeyPathCG_yAKYbctFShyQ7GyXEfu_Tf3npf_n' is not a key for its COMDAT.

$"$sShySiGIgo_AAIegr_TR0133$s11Observation0A9RegistrarV5State33_5AE0855755CD62D4521FC18D42BC1E4BLLV16registerTracking3for6didSetSiShys10AnyKeyPathCG_yAKYbctFShyQ7GyXEfu_Tf3npf_n" = comdat any

define linkonce_odr hidden swiftcc void @"$sShySiGIgo_AAIegr_TR0133$s11Observation0A9RegistrarV5State33_5AE0855755CD62D4521FC18D42BC1E4BLLV16registerTracking3for6didSetSiShys10AnyKeyPathCG_yAKYbctFShyQ7GyXEfu_Tf3npf_n"(ptr noalias nocapture sret(%TSh) %0) #0 comdat {
  store ptr @_swiftEmptySetSingleton, ptr %0, align 8
  ret void
}

The function does not have a key for the COMDAT - comdat vs comdat($"$sShySiGIgo_AAIegr_TR0133$s11Observation0A9RegistrarV5State33_5AE0855755CD62D4521FC18D42BC1E4BLLV16registerTracking3for6didSetSiShys10AnyKeyPathCG_yAKYbctFShyQ7GyXEfu_Tf3npf_n") is what would key it.

[hjyamauchi]

I started a local build with this in case it will be still useful

[fhahn]

Please test with following PR:
swiftlang/llvm-project#10112

@swift-ci test

[fhahn]

@compnerd @hjyamauchi I managed to get a reproducer out of the build logs. IIUC the issue was the we dropped the combat from one of the merged functions. Fixing that via swiftlang/llvm-project@6f1edfc seems to work.

I'll also prepare a patch for upstream.

[fhahn]

@compnerd @hjyamauchi The patch for upstream is here llvm/llvm-project#130583

[fhahn]

Please test with following PR:
swiftlang/llvm-project#10112

@swift-ci test

[fhahn]

Please test with following PR:
swiftlang/llvm-project#10112

@swift-ci test

[fhahn]

@swift-ci please smoke test

[fhahn]

Please test with following PR:
swiftlang/llvm-project#10112

@swift-ci test

[fhahn]

Please test with following PR:
swiftlang/llvm-project#10112

@swift-ci please smoke test