[Coro] RetconOnceDynamic: Popless return on null allocator. #10132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'swiftcorocc' calling convention is a variant of 'swiftcc', but additionally allows the 'swiftcorocc' function to have partial-pop/restore-less returns. These restore-less returns don't fully restore the stack in their epilog, thereby allowing the caller to access some stack allocations made in the 'swiftcorocc' callee. As part of that, these returns don't restore SP (but do restore FP). So the most important characteristic of a 'swiftcorocc' call is that it forces the caller function to access its stack through FP, like it does with e.g., variable-size allocas. This patch only implements the 'swiftcorocc' keyword and CallingConv, but doesn't implement its support on any target yet.
When the coroutine is using the swiftcorocc convention, branch on the nullness of the allocator argument. If it's null, use a popless return. Otherwise, use a regular return.
|
@swift-ci please test |
|
@swift-ci please test llvm |
aschwaighofer
approved these changes
Feb 28, 2025
|
@swift-ci please test windows platform |
nate-chandler
merged commit aec968d
into
swiftlang:stable/20240723
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the coroutine is using the
swiftcoroccconvention, newly added here, branch on the nullness of the allocator argument. If it's null, use a popless return. Otherwise, use a regular return.