[CoroutineAccessors] Use swiftcorocc if available. #79685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it's available, use an open-coded allocator function that returns an alloca without popping if the allocator is nullptr and otherwise calls swift_coro_alloc. When it's not available, use the malloc allocator in the synchronous context.
nate-chandler
force-pushed
the
general-coro/20250227/1
branch
from
420d8cc to
d1f1b4c
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
|
@swift-ci please test macos platform |
|
Do you have a pointer to the LLVM side of this change? We need to reach out to microsoft to allocate the additional calling convention in the name decoration :( |
|
... it is understood by all involved that these drafts will be followed up by tests |
|
@compnerd I don't think the clang frontend change exists yet |
|
@swift-ci please smoke test |
nate-chandler
requested review from
rjmccall,
ktoso,
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it's available, use an open-coded allocator function that returns an
allocawithout popping if the allocator isnullptrand otherwise callsswift_coro_alloc. When it's not available, use themallocallocator in the synchronous context.