[lldb] Add summary formatter for TaskPriority #10205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
A follow up change will change the type of |
kastiglione
added a commit
that referenced
this pull request
Mar 10, 2025
Changes the type of `enqueuePriority` to `TaskPriority`. This allows Tasks to be displayed using human readable names added in #10205 (`TaskPriority` summary provider).
kastiglione
added a commit
that referenced
this pull request
Mar 11, 2025
Add a summary formatter for `TaskPriority` to print values with the names of the constants. See https://developer.apple.com/documentation/swift/taskpriority Some values have more than one name, ex `high` and `userInitiated` are the same value. The [definition of `TaskPriority`](https://github.com/swiftlang/swift/blob/28f96411c9a1fe9c8768ac48c24a6974973876ff/stdlib/public/Concurrency/Task.swift#L308-L331) defines some some constants in terms of others. This summary formatter uses the seemingly "primary" names. As a result, if a user expects to see `userInitiated`, they will see `high` instead. Similarly, they'll see `low` instead of `utility`, and `medium` instead of `default`. (cherry-picked from commit de43ec3)
kastiglione
added a commit
that referenced
this pull request
Mar 11, 2025
Add a summary formatter for `TaskPriority` to print values with the names of the constants. See https://developer.apple.com/documentation/swift/taskpriority Some values have more than one name, ex `high` and `userInitiated` are the same value. The [definition of `TaskPriority`](https://github.com/swiftlang/swift/blob/28f96411c9a1fe9c8768ac48c24a6974973876ff/stdlib/public/Concurrency/Task.swift#L308-L331) defines some some constants in terms of others. This summary formatter uses the seemingly "primary" names. As a result, if a user expects to see `userInitiated`, they will see `high` instead. Similarly, they'll see `low` instead of `utility`, and `medium` instead of `default`. (cherry-picked from commit de43ec3)
kastiglione
added a commit
that referenced
this pull request
Mar 11, 2025
kastiglione
added a commit
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a summary formatter for
TaskPriorityto print values with the names of the constants. See https://developer.apple.com/documentation/swift/taskprioritySome values have more than one name, ex
highanduserInitiatedare the same value. The definition ofTaskPrioritydefines some some constants in terms of others. This summary formatter uses the seemingly "primary" names. As a result, if a user expects to seeuserInitiated, they will seehighinstead. Similarly, they'll seelowinstead ofutility, andmediuminstead ofdefault.