Skip to content

[lldb] Add summary formatter for TaskPriority #10205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions lldb/source/Plugins/Language/Swift/SwiftFormatters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1419,6 +1419,38 @@ bool lldb_private::formatters::swift::TypePreservingNSNumber_SummaryProvider(
return false;
}

bool lldb_private::formatters::swift::TaskPriority_SummaryProvider(
ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) {
uint64_t raw_value = UINT8_MAX;
if (auto child_sp = valobj.GetChildMemberWithName("rawValue"))
if (auto synthetic_sp = child_sp->GetSyntheticValue())
raw_value = synthetic_sp->GetValueAsUnsigned(UINT8_MAX);
if (raw_value >= UINT8_MAX)
return false;

switch (raw_value) {
case 0x19:
// Also .userInitiated
stream.PutCString(".high");
break;
case 0x15:
// Also .default (deprecated)
stream.PutCString(".medium");
break;
case 0x11:
// Also .utilitiy
stream.PutCString(".low");
break;
case 0x09:
stream.PutCString(".background");
break;
default:
stream.Format("{0}", raw_value);
break;
}
return true;
}

namespace {

/// Enumerate the kinds of SIMD elements.
Expand Down
3 changes: 3 additions & 0 deletions lldb/source/Plugins/Language/Swift/SwiftFormatters.h
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ bool ObjC_Selector_SummaryProvider(ValueObject &valobj, Stream &stream,
bool TypePreservingNSNumber_SummaryProvider(ValueObject &valobj, Stream &stream,
const TypeSummaryOptions &options);

bool TaskPriority_SummaryProvider(ValueObject &valobj, Stream &stream,
const TypeSummaryOptions &options);

SyntheticChildrenFrontEnd *EnumSyntheticFrontEndCreator(CXXSyntheticChildren *,
lldb::ValueObjectSP);

Expand Down
4 changes: 4 additions & 0 deletions lldb/source/Plugins/Language/Swift/SwiftLanguage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,10 @@ static void LoadSwiftFormatters(lldb::TypeCategoryImplSP swift_category_sp) {
AddCXXSummary(swift_category_sp, staticstring_summary_provider,
"Swift.StaticString summary provider",
ConstString("Swift.StaticString"), summary_flags);
AddCXXSummary(swift_category_sp,
lldb_private::formatters::swift::TaskPriority_SummaryProvider,
"Swift TaskPriority summary provider", "Swift.TaskPriority",
summary_flags);
summary_flags.SetSkipPointers(false);
// this is an ObjC dynamic type - as such it comes in pointer form
// NSContiguousString* - do not skip pointers here
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
SWIFT_SOURCES := main.swift
SWIFTFLAGS_EXTRAS := -parse-as-library
include Makefile.rules
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import lldb
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
from lldbsuite.test import lldbutil


class TestCase(TestBase):

@swiftTest
def test(self):
"""Test summary formatter for TaskPriority."""
self.build()
lldbutil.run_to_source_breakpoint(
self, "break here", lldb.SBFileSpec("main.swift")
)
self.expect(
"frame var",
substrs=[
"high = .high",
"medium = .medium",
"low = .low",
"background = .background",
"custom = 15",
],
)
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
@main struct Entry {
static func main() {
let high = TaskPriority.high
let medium = TaskPriority.medium
let low = TaskPriority.low
let background = TaskPriority.background
let custom = TaskPriority(rawValue: 15)
print("break here")
}
}