[lldb] Check if C++ interop and embedded Swift are enabled on CU instead of whole module #10279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
approved these changes
Mar 17, 2025
kastiglione
approved these changes
Mar 17, 2025
|
@swift-ci test |
Checking if C++ interop is enabled can be extremely slow if the project is big enough. We have changed this to checking only the compile unit instead, but one usage of the old API slipped by. rdar://147009063
When deciding whether to format a C++ type as a Swiftified type or not, checking if Swift/C++ interop is enabled on the entire target can be very expensive for big projects, and may not swiftify types that should be. rdar://117708944 (cherry picked from commit fe06ebc)
Reading debug info of an entire module to check whether embedded Swift is enabled or not can be very slow. This patch replaces that check with only checking the compile unit instead. rdar://147009063
augusto2112
force-pushed
the
fix-interop-checking-mod
branch
from
c2c8cdb to
03ee42c
Compare
|
@swift-ci test |
augusto2112
changed the title
kastiglione
reviewed
Mar 18, 2025
|
@swift-ci test macOS |
|
@swift-ci test macos |
| lldb::SymbolContextItem::eSymbolContextModule); | ||
|
|
||
| // If there is a compile unit, use that to check if C++ interop should be | ||
| // enabled. If there is no compiler unit, use the module. If neither |
| @@ -2653,7 +2650,7 @@ static bool ShouldEnableCXXInterop(CompileUnit *cu) { | |||
| if (unit.get() == cu) { | |||
| if (cu->GetLanguage() == eLanguageTypeSwift) | |||
| for (const char *arg : args.GetArgumentArrayRef()) | |||
| if (strcmp(arg, "-enable-experimental-cxx-interop") == 0) | |||
| if (strcmp(arg, flag) == 0) | |||
There was a problem hiding this comment.
Do we not have a DWARF attribute for this?
| @@ -2663,6 +2660,15 @@ static bool ShouldEnableCXXInterop(CompileUnit *cu) { | |||
| return false; | |||
| } | |||
|
|
|||
| /// Determine whether this CU was compiled with C++ interop enabled. | |||
There was a problem hiding this comment.
this comment should be in the header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if C++ interop is enabled can be extremely slow if the project is big enough. We have changed this to checking only the compile unit instead, but one usage of the old API slipped by.
rdar://147009063