[cherry-pick][lldb] Check if C++ interop and embedded Swift are enabled on CU instead of whole module #10303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking if C++ interop is enabled can be extremely slow if the project is big enough. We have changed this to checking only the compile unit instead, but one usage of the old API slipped by. rdar://147009063 (cherry picked from commit e1099ae)
When deciding whether to format a C++ type as a Swiftified type or not, checking if Swift/C++ interop is enabled on the entire target can be very expensive for big projects, and may not swiftify types that should be. rdar://117708944 (cherry picked from commit fe06ebc) (cherry picked from commit 234b15b)
Reading debug info of an entire module to check whether embedded Swift is enabled or not can be very slow. This patch replaces that check with only checking the compile unit instead. rdar://147009063 (cherry picked from commit 03ee42c)
|
@swift-ci test |
augusto2112
changed the title
|
@swift-ci test |
adrian-prantl
approved these changes
Mar 21, 2025
|
Thanks for this! 🙌 |
|
Having merged this, it will be available in the downloadable nightly toolchains. I cannot comment on future Xcode releases. |
|
Thank you so much @adrian-prantl and team 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: this fixes a regression where LLDB scans all of the compile units of a module to find out if a program was compiled with C++ interop or Embedded Swift enabled, and instead only parses one compile unit to find out that information. This mainly affects debugging very large programs, which are slowed by multiple seconds without the fix.
Risk: Low. The commit with the biggest change was shipped in release/6.0 (here) but somehow was not cherry picked into 6.1. The other two, more recent commits simply reuse the functionality in new call sites.
Issues: rdar://147009063
Original PRs: #10279
Reviewers: @adrian-prantl @kastiglione