Skip to content

[lldb] Check if interop is enabled only on compile unit #8677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

augusto2112
Copy link

When deciding whether to format a C++ type as a Swiftified type or not, checking if Swift/C++ interop is enabled on the entire target can be very expensive for big projects, and may not swiftify types that should be.

rdar://117708944

@augusto2112 augusto2112 requested a review from adrian-prantl May 1, 2024 23:06
@augusto2112
Copy link
Author

@swift-ci test

@augusto2112 augusto2112 force-pushed the move-interop-check branch from 60fdab4 to 02e8041 Compare May 2, 2024 17:05
@augusto2112
Copy link
Author

@swift-ci test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually, this looks like the right thing to do. Let me know why the test fails....

@augusto2112
Copy link
Author

@swift-ci test

@augusto2112 augusto2112 force-pushed the move-interop-check branch from 02e8041 to 5a5c8d8 Compare May 7, 2024 19:54
@augusto2112
Copy link
Author

@swift-ci test

When deciding whether to format a C++ type as a Swiftified type or not,
checking if Swift/C++ interop is enabled on the entire target can be
very expensive for big projects, and may not swiftify types that should
be.

rdar://117708944
@augusto2112 augusto2112 force-pushed the move-interop-check branch from 5a5c8d8 to fe06ebc Compare May 7, 2024 22:16
@augusto2112
Copy link
Author

@swift-ci test

@adrian-prantl adrian-prantl merged commit b9a2243 into swiftlang:swift/release/6.0 May 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants