[lldb][swift] Improve async stepping with arm64e #10671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
felipepiovezan
changed the title
With arm64e, many more branches are generated, which cause the debugger to stop more often while stepping. Among those stops are code regions where the debugger gets confused about what is stored in the async register stack slot. This commit revives a heuristic that was previously used by default for all architectures and that works in all PC addresses, but that sacrifices unwinding o recursive functions. It is only used if the target is arm64e.
…geRuntime This is required so that the breakpoint may be resolved correctly in case the address has been signed.
felipepiovezan
force-pushed
the
felipe/arm64e_unwind_heuristic
branch
from
f93e511 to
be2f5ca
Compare
felipepiovezan
changed the title
|
@swift-ci test |
The code comparing async context addresses need to strip any pointer authentication bits, otherwise the integer comparison will always fail.
felipepiovezan
force-pushed
the
felipe/arm64e_unwind_heuristic
branch
from
be2f5ca to
6e361c7
Compare
felipepiovezan
commented
May 13, 2025
| @@ -76,25 +76,27 @@ struct MockStackID : StackID { | |||
| }; | |||
|
|
|||
| TEST_F(StackIDTest, StackStackCFAComparison) { | |||
| auto process = MockProcess(m_target_sp, Listener::MakeListener("dummy")); | |||
There was a problem hiding this comment.
In case you're puzzled by this change: FixDataAddress indirectly calls "shared_from_this" on the process class, so it can't be stack allocated.
|
@swift-ci test |
adrian-prantl
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(review each commit in isolation)
This PR improves arm64e swift async stepping by: