[BoundsSafety][APINotes] Add support for bounds safety annotations #10728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delcypher
added
the
clang:bounds-safety
|
@swift-ci test |
|
@swift-ci test llvm |
hnrklssn
approved these changes
May 22, 2025
|
I'm going to assume these failures are unrelated. |
|
Ah the tests fail on Linux: |
|
I probably need to cherry-pick. |
This cherry-picks ``` commit e5e04cd Author: Henrik G. Olsson <[email protected]> Date: Mon Feb 3 10:25:30 2025 -0800 Revert "Revert "[APINotes] Add support for bounds safety annotations"" This reverts commit 7cbd1e7. ``` from the `swift/release/6.2` branch (landed in swiftlang#9942). Conflicts: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/Sema.h clang/lib/APINotes/APINotesFormat.h Below is the original commit message. rdar://151820159 --- [APINotes] Add support for bounds safety annotations This adds support for annotating function parameters with __counted_by, __sized_by, __counted_by_or_null, __sized_by_or_null, and __ended_by, using API notes. The main content of handlePtrCountedByEndedByAttr is extracted to applyPtrCountedByEndedByAttr and decoupled from ParsedAttr. The helper function ParseBoundsAttributeArgFromString is added to make it possible to parse count expressions from SemaAPINotes. The current implementation of __terminated_by/__null_terminated makes it harder to extract from the iterative type processing, but since it doesn't require any extra context to parse the attribute, it can be applied using the normal Type override instead. rdar://139830881
This was originally landed in `stable/20240723` (swiftlang#9901) and this patch cherry-picks it to `main`. rdar://143701027 (cherry picked from commit 013acca)
These test cases use clang modules. TypeCoupledDeclRefInfo serialization/deserialization is currently broken on Linux, so disable these tests until it's been resolved. This a cherry-pick of a change that was originally landed in swiftlang#10009 origianlly. rdar://144275431 (cherry picked from commit 9fbb19c)
delcypher
force-pushed
the
dliew/rdar-139830881-main
branch
from
3c968ed to
6936f54
Compare
|
@swift-ci test llvm |
* Unguard tests that were crashing on Linux * Fix TypeCoupledDeclRefInfo (de-)serialization bug There were two issues here: 1) Deserialization relied on a specific argument evaluation order, which is unspecified. 2) IsMember was not (de-)serialized. This problem was originally tracked by rdar://144275431 and rdar://151820159 tracks landing the missing cherry-pick to the `next` branch. (cherry picked from commit aeb1272)
|
@swift-ci test llvm |
|
Adding this missing change: |
rapidsna
approved these changes
May 22, 2025
|
Linux has these tests failures. I'm going to assume these are unrelated. |
|
I'm going to land now to unblock myself from landing more changes. The macOS tests pass for me locally so that's fairly strong signal that this PR is ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks e5e04cd (#9942) and 013acca (#9901) which were landed in
stable/20240723but not themainbranch.