Skip to content

[lldb][test] Build Swift Obj-C header separately #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

hamishknight
Copy link

Emitting an Obj-C header isn't supported with -primary-file, as the header is emitted for the whole module. Instead, split the header generation out into its own target.

@adrian-prantl
Copy link

There is no automerger from swift/master into swift/master-next. Please also create a secondary PR with this commit cherry-picked to swift/master-next!

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks mostly good!

Emitting an Obj-C header isn't supported with
`-primary-file`, as the header is emitted for
the whole module. Instead, split the header
generation out into its own target.
@hamishknight
Copy link
Author

swiftlang/swift#32403

@swift-ci please test

@adrian-prantl adrian-prantl self-requested a review June 18, 2020 17:17
Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to push to swift/master-next, too.

@hamishknight hamishknight merged commit ec955e5 into swiftlang:swift/master Jun 18, 2020
@hamishknight hamishknight deleted the whole-in-one branch June 18, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants