[Frontend] Move some stats + outputs to end of pipeline #32403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please clean test macOS |
CodaFi
approved these changes
Jun 16, 2020
|
@CodaFi Hmm, how about we factor out a |
This better fits the model of an inverted pipeline and ensures we capture all the work performed.
Move both the loaded module trace output and "additional whole module outputs" to the end of the pipeline, ensuring to preserve the behaviour where we skip them if we encountered an error.
The use of `SWIFT_DEFER` previously meant that we may return `false` from `performCompile` even if an error was produced from `performEndOfPipelineActions`. To remedy this, introduce a lambda that both calls `performEndOfPipelineActions`, and checks to see if there was an error. Then, enforce that all exit paths call this lambda.
Previously we may have silently bailed if a private module interface path was specified, but the frontend action didn't support it. Instead, make sure we enforce the same restrictions that we enforce for public module interfaces.
hamishknight
force-pushed
the
over-and-out
branch
from
e1770eb to
0825fa5
Compare
|
@swift-ci please test |
|
Merging for now, will work on cleaning up the interface in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some stat collection and supplementary output logic to
performEndOfPipelineActionsto better fit the model of an inverted pipeline.