[lldb] Fix missing characters when autocompleting LLDB commands in REPL #1388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realized that the main code change should probably go to the upstream, and only the test belongs here |
|
Fix in https://reviews.llvm.org/D82835 and tests in this PR |
|
@Teemperor Please have a look at this accompanying Swift REPL test for https://reviews.llvm.org/D82835 |
|
LGTM, thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tabbing to autocomplete LLDB commands in the Swift REPL, characters would at best be missing from the completed command, but at worst cause the REPL to crash due to out of range string access
https://bugs.swift.org/browse/SR-12867