Cherry-pick "[lldb] Fix missing characters when autocompleting LLDB commands in REPL" to swift/master #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Teemperor Porting this recent fix to swift/master to be able to resolve the bug report as fixed. I'm not fully familiar with the branching strategy used, whether this fix should go into any other stable/release branch at this time? |
|
The LLDB change goes into stable/ and the swift test goes into swift/master (it's a bit confusing). I did the cherry-pick here so you can just drop the LLDB change from this PR and we're all set! |
|
(Also sorry for the delay) |
|
@swift-ci test |
|
The test should also go to |
|
@Teemperor LLDB change dropped, now only Swift REPL test in this PR |
|
@swift-ci test |
|
@Teemperor @fredriss Anything missing, or ready to merge? |
Teemperor
approved these changes
Jul 15, 2020
|
This is only a test so I'll go ahead and merge this. The change for this already landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of recent fix for https://bugs.swift.org/browse/SR-12867 in swift/master-next to swift/master
Differential Revision: https://reviews.llvm.org/D82835