TypeSystem: Avoid the ISO646 spelling of the logical operators #2001
Conversation
Avoid the use of the ISO646 logical operator spelling. This enables the removal of the use of the `ciso646` header which can cause some issues when building Swift.
|
@swift-ci please test |
| @@ -401,9 +401,9 @@ template <> struct less<swift::ClusteredBitVector> { | |||
| for (; iL >= 0 && iR >= 0; --iL, --iR) { | |||
There was a problem hiding this comment.
why does this even exist? Are we putting them into a std::map?
There was a problem hiding this comment.
I couldn't answer that - I don't know why it exists, Im just trying to avoid extension usage. We could try removing it separately I suppose.
There was a problem hiding this comment.
That was more a question for the room — I know you're just the messenger :-)
| @@ -401,9 +401,9 @@ template <> struct less<swift::ClusteredBitVector> { | |||
| for (; iL >= 0 && iR >= 0; --iL, --iR) { | |||
| bool bL = lhs[iL]; | |||
| bool bR = rhs[iR]; | |||
| if (bL and not bR) | |||
There was a problem hiding this comment.
if it were my choice, we should switch everything to use not instead of !
|
The spelling here requires the use of |
Avoid the use of the ISO646 logical operator spelling. This enables the removal of the use of the
ciso646header which can cause some issues when building Swift.