Skip to content

TypeSystem: Avoid the ISO646 spelling of the logical operators #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020
Merged

TypeSystem: Avoid the ISO646 spelling of the logical operators #2001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,9 +401,9 @@ template <> struct less<swift::ClusteredBitVector> {
for (; iL >= 0 && iR >= 0; --iL, --iR) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this even exist? Are we putting them into a std::map?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't answer that - I don't know why it exists, Im just trying to avoid extension usage. We could try removing it separately I suppose.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was more a question for the room — I know you're just the messenger :-)

bool bL = lhs[iL];
bool bR = rhs[iR];
if (bL and not bR)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it were my choice, we should switch everything to use not instead of !

if (bL && !bR)
return false;
if (bR and not bL)
if (bR && !bL)
return true;
}
return false;
Expand Down