Skip to content

Add an end-to-end test fo function arguments in an async function. #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

adrian-prantl
Copy link

No description provided.

@adrian-prantl
Copy link
Author

test with swiftlang/swift#35028
@swift-ci test

@adrian-prantl adrian-prantl merged commit 117fc5b into swiftlang:swift/main Dec 14, 2020
Copy link

@kastiglione kastiglione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple small questions that weren't too important, but apparently forgot to hit the button

@@ -0,0 +1,17 @@
import Swift

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly, yes, to make runAsyncAndBlock available.

print("hello")
}

func sayGeneric<T>(_ msg: T) async {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is generic relevant to the test?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because it pushes an extra hidden function argument for the generic type metadata into the coroutine frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants